Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(example): Custom web proxies usage and documentation #2729

Merged
merged 6 commits into from
Dec 18, 2024
Merged

feat(example): Custom web proxies usage and documentation #2729

merged 6 commits into from
Dec 18, 2024

Conversation

ivaylogarnev-limechain
Copy link
Contributor

Description:
This PR introduces an example where the Hedera SDK use a custom network with multiple gRPC web proxies in a React application within examples folder. It includes steps for setting up the operator account, defining the gRPC proxies, and executing a transfer transaction through the configured network/

Related issue(s):
#2606

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

agadzhalov
agadzhalov requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's rename the directory instead of custom-grpc-network to be custom-grpc-web-proxies-network
  • Minor formatting changes

@ivaylogarnev-limechain
fix: Comments and CommonJS test
8073b8b 
Signed-off-by: ivaylogarnev-limechain <[email protected]>
@ivaylogarnev-limechain
fix: Typo in README
b763167 
Signed-off-by: ivaylogarnev-limechain <[email protected]>
@ivaylogarnev-limechain ivaylogarnev-limechain linked an issue Dec 18, 2024 that may be closed by this pull request
Document how a developer can update the SDK to enter gRPC web proxies for their custom network #2606
Closed
@ivaylogarnev-limechain ivaylogarnev-limechain changed the title feat: Example for custom web proxies usage and documentation chore(feat): Example for custom web proxies usage and documentation Dec 18, 2024
@ivaylogarnev-limechain ivaylogarnev-limechain changed the title chore(feat): Example for custom web proxies usage and documentation feat(example): Custom web proxies usage and documentation Dec 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

agadzhalov
agadzhalov approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @ivaylogarnev-limechain

@ivaylogarnev-limechain ivaylogarnev-limechain merged commit 6994223 into main Dec 18, 2024
10 checks passed
@ivaylogarnev-limechain ivaylogarnev-limechain deleted the feat/grpc-web-proxies-custom-network-usage branch December 18, 2024 13:58
@ivaylogarnev-limechain ivaylogarnev-limechain mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu was automatically assigned from hashgraph/platform-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth was automatically assigned from hashgraph/hedera-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how a developer can update the SDK to enter gRPC web proxies for their custom network
2 participants
@ivaylogarnev-limechain @agadzhalov